From 279ae37f79fdba031a079616d904bd4b925e021f Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Fri, 19 Mar 2021 18:44:43 -0700 Subject: drop some pointless & incorrect :CHECK subroutines Pointless because there is no point in running a check that PROPAPPAPPLY/PROPAPPUNAPPLY is just going to run again. Incorrect because always returning nil means unapplying the property will never happen. Signed-off-by: Sean Whitton --- src/propspec.lisp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/propspec.lisp') diff --git a/src/propspec.lisp b/src/propspec.lisp index d39f732..5979187 100644 --- a/src/propspec.lisp +++ b/src/propspec.lisp @@ -286,13 +286,11 @@ expression." (define-function-property-combinator eseqprops (&rest propapps) (:retprop :type (collapse-types (mapcar #'propapptype propapps)) - :check (constantly nil) :hostattrs (lambda () (mapc #'propappattrs propapps)) :apply (lambda () (apply-and-print propapps)))) (define-function-property-combinator seqprops (&rest propapps) (:retprop :type (collapse-types (mapcar #'propapptype propapps)) - :check (constantly nil) :hostattrs (lambda () (mapc #'propappattrs propapps)) :apply (lambda () (with-skip-failed-changes @@ -306,7 +304,6 @@ apply the elements of REQUIREMENTS in reverse order." (define-function-property-combinator silent-seqprops (&rest propapps) (:retprop :type (collapse-types (mapcar #'propapptype propapps)) - :check (constantly nil) :hostattrs (lambda () (mapc #'propappattrs propapps)) :apply (lambda () (with-skip-failed-changes @@ -347,7 +344,6 @@ ON-CHANGE in order." :desc (get (car propapp) 'desc) :hostattrs (lambda (&rest args) (apply #'propattrs (car propapp) args)) - :check (get (car propapp) 'check) :apply (lambda (&rest args) (unless (eq (propappapply (cons (car propapp) args)) :no-change) -- cgit v1.2.3