From afbb72dfca9489f0e9b56171d9c9df6baa015798 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Fri, 5 Mar 2021 13:55:34 -0700 Subject: add TODO regarding the property type check in EVAL-PROPSPEC Signed-off-by: Sean Whitton --- src/propspec.lisp | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/propspec.lisp') diff --git a/src/propspec.lisp b/src/propspec.lisp index 8b5d74f..a348f5c 100644 --- a/src/propspec.lisp +++ b/src/propspec.lisp @@ -175,6 +175,12 @@ an atomic property application." (defmethod eval-propspec ((propspec propspec)) "Apply properties as specified by PROPSPEC." + ;; TODO should have this check in the closures produced by DEFPROP too, so + ;; that we will catch attempts to programmatically apply :LISP properties. + ;; for the check here, could offer a restart to apply all the properties up + ;; to but not including the first :LISP property (we don't just want to + ;; apply all non-:LISP because that might violate dependencies established + ;; by the order of the elements of PROPSPEC's props) (when (and (subtypep (class-of *connection*) 'posix-connection) (eq :lisp (propspec->type propspec))) (error "Cannot apply :LISP properties using a POSIX connection")) -- cgit v1.2.3