From 03c33aa0b4b775bace17c10bbfbd85da44a6f9a2 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 5 May 2017 21:36:26 -0400 Subject: fix from nomeata's review He pointed out that Just () and Nothing would hash the same. Luckily Maybe Hash is the only Maybe type that needs to be hashed, so specialize the instance. --- .../comment_2_4a25b8ee6e438a031e875078ffb1d125._comment | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 doc/protocol/comment_2_4a25b8ee6e438a031e875078ffb1d125._comment (limited to 'doc') diff --git a/doc/protocol/comment_2_4a25b8ee6e438a031e875078ffb1d125._comment b/doc/protocol/comment_2_4a25b8ee6e438a031e875078ffb1d125._comment new file mode 100644 index 0000000..935570d --- /dev/null +++ b/doc/protocol/comment_2_4a25b8ee6e438a031e875078ffb1d125._comment @@ -0,0 +1,10 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2017-05-06T01:34:39Z" + content=""" +Thanks for that review. That would indeed be bad. To avoid that +potential problem, I've specialized the instance to +`Hashable (Maybe Hash)`, which is the only Maybe value that currently +needs to be hashed. +"""]] -- cgit v1.2.3