From 35d088e41bc28eb45d2fd8d5179fb0e914a566fa Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Mon, 4 Apr 2022 18:33:06 -0700 Subject: locmaint ignores loose ~/src files under git worktrees & add TODOs --- perl5/Local/Homedir.pm | 7 +++---- perl5/Local/MrRepo/Repo/Git.pm | 4 ++++ 2 files changed, 7 insertions(+), 4 deletions(-) (limited to 'perl5') diff --git a/perl5/Local/Homedir.pm b/perl5/Local/Homedir.pm index 8d4be685..3030f4b0 100644 --- a/perl5/Local/Homedir.pm +++ b/perl5/Local/Homedir.pm @@ -209,10 +209,9 @@ sub say_block (*$$) { } sub is_repo { - my $repo = shift; - # usefully excludes git worktrees - # e.g. s.t. src_register_all ignores ~/src/emacs-snapshot - return -d "$repo/.git" || -d "$repo/.hg"; + my ($repo, $include_worktrees) = @_; + return -d "$repo/.git" || -d "$repo/.hg" + || $include_worktrees && -f "$repo/.git"; } 1; diff --git a/perl5/Local/MrRepo/Repo/Git.pm b/perl5/Local/MrRepo/Repo/Git.pm index 5c9737bc..c0890203 100644 --- a/perl5/Local/MrRepo/Repo/Git.pm +++ b/perl5/Local/MrRepo/Repo/Git.pm @@ -54,6 +54,10 @@ sub review { my $issues = 0; + # TODO Checks (1) and (2) should be done for each worktree. + # + # TODO Similarly, mr's git_status action might look at each worktree? + # 1. Check for a detached HEAD which is not contained in any local # or remote ref, and might therefore contain useful work try { -- cgit v1.2.3