From 7384ec6416cbcea12a65db058e5a65e40d3a157f Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Fri, 1 Jan 2021 13:52:37 +0200 Subject: Add warning comments abound binding keys in Isearch maps * lisp/isearch.el (isearch-mode-map) (minibuffer-local-isearch-map): Add comments which warn against wantonly rebinding unbound keys. --- lisp/isearch.el | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lisp/isearch.el b/lisp/isearch.el index ac0ebc735d5..cbe72efb801 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -655,6 +655,10 @@ This is like `describe-bindings', but displays only Isearch keys." (if isearch-success 'isearch-abort binding)))) map)) +;; Note: Before adding more key bindings to this map, please keep in +;; mind that any unbound key exits Isearch and runs the command bound +;; to it in the local or global map. So in effect every key unbound +;; in this map is implicitly bound. (defvar isearch-mode-map (let ((i 0) (map (make-keymap))) @@ -819,6 +823,10 @@ This is like `describe-bindings', but displays only Isearch keys." :image '(isearch-tool-bar-image "left-arrow"))) map)) +;; Note: Before adding more key bindings to this map, please keep in +;; mind that any unbound key exits Isearch and runs the command bound +;; to it in the local or global map. So in effect every key unbound +;; in this map is implicitly bound. (defvar minibuffer-local-isearch-map (let ((map (make-sparse-keymap))) (set-keymap-parent map minibuffer-local-map) -- cgit v1.2.3