summaryrefslogtreecommitdiff
path: root/email-print-mime-structure
Commit message (Collapse)AuthorAge
* email-print-mime-structure, imap-dl: clean up types with mypy 1.9.0Daniel Kahn Gillmor13 days
| | | | Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: handle one-part PKCS#7 signature objectsDaniel Kahn Gillmor2019-11-28
| | | | | | | | | | | | | | | | PKCS#7 offers a signed-only mode which is distinct from multipart/signed. This mode is more robust to breakage by transforming MTAs, but it is also unreadable *unless* the receiver knows how to cope with S/MIME. See https://tools.ietf.org/html/rfc8551#section-3.5 for more details about the different formats. email-print-mime-structure should now be able to handle these messages and display the structure of their content as well. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: Change pipe_decrypt to pipe_transformDaniel Kahn Gillmor2019-11-28
| | | | | | | | | | | I plan to use the same harness to try to transform other leaf subparts that might be extractable into a MIME subtree, not just decryption. So give it a more generic name. No functional change. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: decrypt S/MIME parts with OpenSSLDaniel Kahn Gillmor2019-11-28
| | | | | | | | | | If the user supplies a secret key like the ones found in https://www.ietf.org/id/draft-dkg-lamps-samples-01.html, then email-print-mime-structure will try to use that for decryption of CMS-encrypted (S/MIME) message parts. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: decrypt S/MIME parts using gpgsmDaniel Kahn Gillmor2019-11-28
| | | | | | | | | | Decrypt ciphertext using gpgsm if the user has indicated that it's ok. This includes a new element in the test suite, which uses secret key material from https://www.ietf.org/id/draft-dkg-lamps-samples-01.html Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: move decrypt_part to its own functionDaniel Kahn Gillmor2019-11-28
| | | | | | | No functional change. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: Generic pipe decryptionDaniel Kahn Gillmor2019-11-28
| | | | | | | No functional change. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: decrypt PGP/MIME parts as bytesDaniel Kahn Gillmor2019-11-28
| | | | | | | | Fully decode the encrypted part before passing it to any decryption mechanism. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: prepare for multiple forms of decryptionDaniel Kahn Gillmor2019-11-21
| | | | | | | | | As we prepare for S/MIME decryption, we want to identify pgp decryption as just one type of decryption. There is no functional change here. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: add --no-use-gpg-agentSean Whitton2019-11-15
| | | | | | | This allows the user to avoid being affected by any future change in the default. Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: change --use-gpg-agent to a simple flagDaniel Kahn Gillmor2019-11-15
| | | | | | | | | | | | | | | Turns out that type=bool doesn't really do what we want it to do (see https://bugs.python.org/issue37564), and there is no built-in easy answer for argparse to accept a boolean value sensibly (e.g. type='bool', which might be able to handle "yes" and "no" and "1" and "0" and "on" and "off" as well as "true" and "false", etc) So rather than implement all of that here, we'll just have --use-gpg-agent as a simple flag. This is an API change, but the previous API has only been out for a few days, and the tool is documented for interactive use. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: add tab completionDaniel Kahn Gillmor2019-11-10
| | | | | | | | This is modeled after the use of argcomplete in diffoscope, and it should be possible to use it for any other pythonic mailscript that uses argparse. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: Add --use-gpg-agent for decryptionDaniel Kahn Gillmor2019-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some cases, the user may want to try to use their own GnuPG secret keys to decrypt encrypted parts of the message. By default it is disabled so that we aren't accidentally triggering the use of user secret key material. Note that gpg(1) says: It is highly recommended to use [--batch] along with the options --status-fd and --with-colons for any unattended use of gpg. I am deliberately choosing to not use either --status-fd or --with-colons for email-print-mime-structure. I'm not using --with-colons because there is no output from GnuPG that we expect to be machine-readable -- we're just looking for the cleartext of whatever ciphertext is in the message part. I'm not using --status-fd because there is nothing actionable we can do with GnuPG status messages, and asking for them would require switching from subprocess.run to subprocess.Popen to take advantage of the pass_fds argument, which in turn would make the script only work in a POSIX environment (I believe, but have not tested, that the script can currently be used on Windows). Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: prepare for other decryption mechanismsDaniel Kahn Gillmor2019-11-10
| | | | | | | | No functional change here: this just prepares for adding other decryption capabilities. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: Restructure pgpy decryptionDaniel Kahn Gillmor2019-11-10
| | | | | | | | This has no functional changes, it's just a reorganization for easier readability. Thanks to Sean Whitton for the suggestion. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: sanity check cryptographic payloadDaniel Kahn Gillmor2019-11-10
| | | | | | | | We want to make sure we're decrypting the thing that we expect. This typecheck should keep us honest. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> Acked-by: Sean Whitton <spwhitton@spwhitton.name>
* drop space before shell redirection operatorSean Whitton2019-11-02
| | | | | | For consistency with the manpage. Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
* email-print-mime-structure: add decryption capabilityDaniel Kahn Gillmor2019-11-02
| | | | | | | | | | | | | | | | | | | | | | | | | | Add simple decryption capability for email-print-mime-structure, so that it can do stuff like this: $ email-print-mime-structure --pgpkey alice@openpgp.example.sec.asc < msg.eml └┬╴multipart/encrypted 2190 bytes ├─╴application/pgp-encrypted 11 bytes └─╴application/octet-stream 1613 bytes ↧ (decrypts to) └─╴text/plain 425 bytes $ At the moment, it only works with keys that can be found in the filesystem, and when the pgpy module is installed. Possible future work: - try using gpg to do the decryption from whatever gpg's system capabilities are I've added python3-pgpy to the list of Recommends, since it is not a hard dependency. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: renamed MimePrinter.test() to print_tree()Daniel Kahn Gillmor2019-11-02
| | | | | | No functional changes. This is just a more readable function name. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: add another FIXME about bytecountingDaniel Kahn Gillmor2019-11-02
| | | | Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: Pass parent and nth child info during walkDaniel Kahn Gillmor2019-11-02
| | | | | | | | | No functional change. This is preparatory work to be able to consider the structure of each part and determine whether we should consider trying to decrypt it. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: nbytes should show as a decimal integerDaniel Kahn Gillmor2019-11-02
| | | | | | No functional changes. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: parse argmentsDaniel Kahn Gillmor2019-11-02
| | | | | | | | This adds a -h and --help option, which is currently pretty useless. But the argparse will become useful shortly. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: put main() into its own functionDaniel Kahn Gillmor2019-11-02
| | | | | | | No functional changes. This is a refactoring commit to provide some non-global scoping and easier readability. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: refactor to a classDaniel Kahn Gillmor2019-11-02
| | | | | | | | | | | We will need to send arguments to the printer, so it's handy to wrap the functionality in a class. No functional changes. This diff is probably best reviewed with whitespace changes ignored. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* email-print-mime-structure: be typesafeDaniel Kahn Gillmor2019-11-01
| | | | | | | | This adds enough typechecking that the following check passes: mypy --strict email-print-mimestructure Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* update email-print-mime-structure headers to include licensingDaniel Kahn Gillmor2019-09-14
| | | | Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
* rename printmimestructure to email-print-mime-structureDaniel Kahn Gillmor2019-09-14
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-19 17:19:13 +0000