diff options
| author | Sean Whitton <spwhitton@spwhitton.name> | 2020-03-10 09:13:57 -0700 |
|---|---|---|
| committer | Sean Whitton <spwhitton@spwhitton.name> | 2020-03-10 09:13:57 -0700 |
| commit | 16b5e5d0592ff442716bc5702fde94d2c02a4971 (patch) | |
| tree | f73aae3ebaa91d631c23232b7ef5b281c5523cc5 | |
| parent | 68c29d68184b93fda6fa8ca2741114859693aa0e (diff) | |
| download | p5-API-GitForge-16b5e5d0592ff442716bc5702fde94d2c02a4971.tar.gz | |
push the gitforge branch using Git::Wrapper again.
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
| -rw-r--r-- | Changes | 4 | ||||
| -rw-r--r-- | lib/API/GitForge/Role/GitForge.pm | 5 |
2 files changed, 5 insertions, 4 deletions
@@ -6,6 +6,10 @@ Revision history for API::GitForge - API::GitForge::Role::GitForge::clean_repo(): try to unprotect fork branches before deleting them, if GitForge API library supports doing this. + - API::GitForge::Role::GitForge::clean_repo(): push the gitforge + branch using Git::Wrapper again. + During early testing, this seemed to hang after pushing to + GitLab installations, but it seems to work well now. 0.002 2020-03-09 12:17:47-07:00 America/Phoenix - Implement API::GitForge::GitLab::_ensure_repo(). diff --git a/lib/API/GitForge/Role/GitForge.pm b/lib/API/GitForge/Role/GitForge.pm index c3459bf..3742553 100644 --- a/lib/API/GitForge/Role/GitForge.pm +++ b/lib/API/GitForge/Role/GitForge.pm @@ -120,10 +120,7 @@ sub clean_fork { $git->add("README.md"); $git->commit({ message => "Temporary fork for pull request(s)" }); - # TODO why does Git::Wrapper hang after pushing the branch to - # GitLab? for now, just use system() to do the push ourselves - system "git", "-C", $git->dir, "push", $fork_uri, "master:gitforge"; - + $git->push($fork_uri, "master:gitforge"); $self->_clean_config_fork($_[0]); # assume that if we had to create the gitforge branch, we just |