summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean Whitton <spwhitton@spwhitton.name>2021-02-09 15:03:01 -0700
committerSean Whitton <spwhitton@spwhitton.name>2021-02-09 15:09:31 -0700
commit2374669e8d59f3d4895e579789c0038027f1b679 (patch)
tree8fc347ec1fa66e6d1d1dc64d0229a9ce1223295d
parent1c3a1a8673743cd5d8f9be3670cbf50772043bc5 (diff)
downloadp5-API-GitForge-2374669e8d59f3d4895e579789c0038027f1b679.tar.gz
fix checking the exit status of the push of the gitforge branch
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
-rw-r--r--Changes2
-rw-r--r--lib/API/GitForge/Role/GitForge.pm4
2 files changed, 4 insertions, 2 deletions
diff --git a/Changes b/Changes
index 1fbbfea..781e2bb 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,8 @@
Revision history for API::GitForge
{{$NEXT}}
+ - API::GitForge::Role::GitForge::clean_fork(): fix checking the exit
+ status of the push of the gitforge branch.
0.005 2020-05-24 08:04:55-07:00 America/Phoenix
- API::GitForge::Role::GitForge::clean_repo(): don't continue if
diff --git a/lib/API/GitForge/Role/GitForge.pm b/lib/API/GitForge/Role/GitForge.pm
index 1301f88..f0c616b 100644
--- a/lib/API/GitForge/Role/GitForge.pm
+++ b/lib/API/GitForge/Role/GitForge.pm
@@ -126,8 +126,8 @@ sub clean_fork {
# but that hangs indefinitely when pushing to (at least) Debian's
# GitLab instance. So just bypass Git::Wrapper and do the push
# ourselves for now
- system qw(git -C), $git->dir, "push", $fork_uri, "master:gitforge"
- or croak "failed to push the gitforge branch to $fork_uri";
+ system qw(git -C), $git->dir, "push", $fork_uri, "master:gitforge";
+ $! and croak "failed to push the gitforge branch to $fork_uri";
$self->_clean_config_fork($_[0]);