From 2374669e8d59f3d4895e579789c0038027f1b679 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Tue, 9 Feb 2021 15:03:01 -0700 Subject: fix checking the exit status of the push of the gitforge branch Signed-off-by: Sean Whitton --- Changes | 2 ++ lib/API/GitForge/Role/GitForge.pm | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Changes b/Changes index 1fbbfea..781e2bb 100644 --- a/Changes +++ b/Changes @@ -1,6 +1,8 @@ Revision history for API::GitForge {{$NEXT}} + - API::GitForge::Role::GitForge::clean_fork(): fix checking the exit + status of the push of the gitforge branch. 0.005 2020-05-24 08:04:55-07:00 America/Phoenix - API::GitForge::Role::GitForge::clean_repo(): don't continue if diff --git a/lib/API/GitForge/Role/GitForge.pm b/lib/API/GitForge/Role/GitForge.pm index 1301f88..f0c616b 100644 --- a/lib/API/GitForge/Role/GitForge.pm +++ b/lib/API/GitForge/Role/GitForge.pm @@ -126,8 +126,8 @@ sub clean_fork { # but that hangs indefinitely when pushing to (at least) Debian's # GitLab instance. So just bypass Git::Wrapper and do the push # ourselves for now - system qw(git -C), $git->dir, "push", $fork_uri, "master:gitforge" - or croak "failed to push the gitforge branch to $fork_uri"; + system qw(git -C), $git->dir, "push", $fork_uri, "master:gitforge"; + $! and croak "failed to push the gitforge branch to $fork_uri"; $self->_clean_config_fork($_[0]); -- cgit v1.2.3