diff options
| author | Joey Hess <joeyh@joeyh.name> | 2017-04-30 13:54:02 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2017-04-30 13:54:02 -0400 |
| commit | b47e621749257331788e82e44d1565cf4d32d04b (patch) | |
| tree | d6c3445be85b05fc58675552fc1bfb4f0ceb375d /TODO | |
| parent | 89d4e18cdb6ed1c3e7916dd66cf907bedf58a549 (diff) | |
| download | debug-me-b47e621749257331788e82e44d1565cf4d32d04b.tar.gz | |
fix probable race in use of restoreHashes
I think there was a race where a SessionKey message had been drained
from the TChan, but not yet added to the developer state, which was
resonsible for recent instability at startup.
It manifested as protocol errors where the prevActivity hash was wrongly
Nothing.
Fixed by adding a MissingHashes type to tag things whose hashes have
been stripped, and adding back the hashes when needed, which always
happens inside atomically blocks, so won't have such a race.
Diffstat (limited to 'TODO')
| -rw-r--r-- | TODO | 3 |
1 files changed, 0 insertions, 3 deletions
@@ -1,6 +1,3 @@ -* Multiple --downloads at the same time or close together fail - with "thread blocked indefinitely in an STM transaction" - Also see it occasionally when connecting with what was --debug. * The current rules for when an Activity Entered is accepted allow it to refer to an older activity than the last one. If echoing is disabled, two Activity Entered could be sent, each pointing at the most recent |