aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean Whitton <spwhitton@spwhitton.name>2021-03-05 13:55:34 -0700
committerSean Whitton <spwhitton@spwhitton.name>2021-03-05 13:56:08 -0700
commitafbb72dfca9489f0e9b56171d9c9df6baa015798 (patch)
tree86d5362d010889344484999480c417b9589a9d82
parent89e39a4032610ce394d7bed233039c3450ba083c (diff)
downloadconsfigurator-afbb72dfca9489f0e9b56171d9c9df6baa015798.tar.gz
add TODO regarding the property type check in EVAL-PROPSPEC
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
-rw-r--r--src/propspec.lisp6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/propspec.lisp b/src/propspec.lisp
index 8b5d74f..a348f5c 100644
--- a/src/propspec.lisp
+++ b/src/propspec.lisp
@@ -175,6 +175,12 @@ an atomic property application."
(defmethod eval-propspec ((propspec propspec))
"Apply properties as specified by PROPSPEC."
+ ;; TODO should have this check in the closures produced by DEFPROP too, so
+ ;; that we will catch attempts to programmatically apply :LISP properties.
+ ;; for the check here, could offer a restart to apply all the properties up
+ ;; to but not including the first :LISP property (we don't just want to
+ ;; apply all non-:LISP because that might violate dependencies established
+ ;; by the order of the elements of PROPSPEC's props)
(when (and (subtypep (class-of *connection*) 'posix-connection)
(eq :lisp (propspec->type propspec)))
(error "Cannot apply :LISP properties using a POSIX connection"))