summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorJoey Hess <joeyh@joeyh.name>2017-04-12 15:42:00 -0400
committerJoey Hess <joeyh@joeyh.name>2017-04-12 15:42:00 -0400
commitbe3cf7447253d08bd55a632409c059cd5894a243 (patch)
tree0e866877a8e55391d2ea2e0d429b0bc5776c4eb9
parent2288820b8a17cf3329b8655c4df1cff63ac735cf (diff)
downloaddebug-me-be3cf7447253d08bd55a632409c059cd5894a243.tar.gz
note potential DOS in the code I just added
-rw-r--r--TODO16
1 files changed, 16 insertions, 0 deletions
diff --git a/TODO b/TODO
index bf98cc8..7fd1f13 100644
--- a/TODO
+++ b/TODO
@@ -1,3 +1,19 @@
* for some reason reset is needed after debug-me exits, despite it trying
to clean up the terminal settings
* set pty size, and forward resizes to the pty (setting new size and SIGWINCH)
+* potential DOS where developer sends Activity Entered that all
+ refer back to the first Activity Seen. This requires the user
+ side to keep a Backlog containing all later Activity Seen, so uses
+ up a lot of memory.
+
+ For this to work, the developer would need to include
+ in their Activity Entered echoData anticipating all the Activity Seen
+ that they have generated. This is doable; for example the developer
+ can send a stream of A's, and then needs to only include the right
+ amount in the echoData.
+
+ Should probably cap the BackLog to some maximum size to prevent
+ this kind of DOS. Dropping old items from the BackLog after some
+ amount of time would also work; after eg 10 seconds it's very
+ unlikely that a Activity Entered will legitimately refer to an
+ old backlog item.