diff options
| author | Joey Hess <joeyh@joeyh.name> | 2017-05-05 11:02:58 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2017-05-05 11:03:48 -0400 |
| commit | be53d40694e59f9ef48d8a8106004623bddc703b (patch) | |
| tree | 9699d7385da6c9276272812d91cb1f913884bb49 /Role/Developer.hs | |
| parent | b8a8b10ab8f2e593d55b7b1ab0d57817939decc0 (diff) | |
| download | debug-me-be53d40694e59f9ef48d8a8106004623bddc703b.tar.gz | |
add protocol version
This is distinct from the wire protocol version used in the websocket
framing of messages. Versioning the high level protocol will let later
features be added.
The user controls the protocol version, since they send the first
several messages. Developers that connect need to avoid using features
from newer protocol versions.
So, developers and servers will need to support the most recent version,
while the user can have an old version of debug-me and it will continue
to work.
This commit changes the protocol buffer encoding, and is the last such
free change. All changes past this point will need to be versioned.
This commit was sponsored by Jochen Bartl on Patreon.
Diffstat (limited to 'Role/Developer.hs')
| -rw-r--r-- | Role/Developer.hs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/Role/Developer.hs b/Role/Developer.hs index 2cdf917..d706a7a 100644 --- a/Role/Developer.hs +++ b/Role/Developer.hs @@ -226,7 +226,7 @@ authUser :: PerhapsSigned PublicKey -> TMChan (Message Entered) -> TMChan (Missi authUser spk ichan ochan devstate logger = do ds <- atomically $ readTVar devstate let msg = ControlMessage $ mkSigned (developerSessionKey ds) - (Control (SessionKey spk)) + (Control (SessionKey spk currentProtocolVersion)) atomically $ writeTMChan ichan msg logger $ Developer msg waitresp $ case spk of @@ -291,7 +291,7 @@ getServerMessage ochan devstate ts = do return (Just (o, User msg)) else return $ Just (ProtocolError ds $ "Bad signature on message from user: " ++ show msg, User msg) -- When other developers connect, learn their SessionKeys. - process (Developer msg@(ControlMessage (Control (SessionKey spk) _))) = do + process (Developer msg@(ControlMessage (Control (SessionKey spk _) _))) = do let sigverifier = mkSigVerifier $ case spk of GpgSigned pk _ _ -> pk UnSigned pk -> pk @@ -334,7 +334,7 @@ getServerMessage ochan devstate ts = do } writeTVar devstate ds' return Beep - processuser _ (ControlMessage (Control c@(SessionKey _) _)) = + processuser _ (ControlMessage (Control c@(SessionKey _ _) _)) = return (GotControl c) processuser _ (ControlMessage (Control c@(SessionKeyAccepted _) _)) = return (GotControl c) @@ -421,7 +421,7 @@ processSessionStart sk ochan logger dsv = do <$> atomically (readTMChan ochan) logger sessionmsg sigverifier <- case sessionmsg of - User (ControlMessage c@(Control (SessionKey spk) _)) -> do + User (ControlMessage c@(Control (SessionKey spk _) _)) -> do let pk = case spk of GpgSigned k _ _ -> k UnSigned k -> k |