blob: 64eed07f7125285380ad588690dfa64a69cdab3a (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
|
[[!comment format=mdwn
username="https://www.joachim-breitner.de/"
nickname="nomeata"
avatar="http://cdn.libravatar.org/avatar/a2112893817513537c6a2c228c04c138a2f68bba57121ab7f267de58fc5171d7"
subject="Code smell in hashing"
date="2017-05-05T23:51:14Z"
content="""
Hi Joey,
I looked through http://source.debug-me.branchable.com/?p=source.git;a=blob;f=Hash.hs;hb=HEAD and since this probably scurity-relevant, allow me to be nitpicky:
```
instance Hashable v => Hashable (Maybe v) where
hash Nothing = hash ()
hash (Just v) = hash v
```
will hash the distinct values `Just ()` and `Nothing` identically. Maybe you don't have any `Maybe ()` type around, but in that case you should maybe document that requirement.
"""]]
|
