diff options
| author | Spencer Baugh <sbaugh@janestreet.com> | 2024-03-26 08:44:25 -0400 |
|---|---|---|
| committer | Dmitry Gutov <dmitry@gutov.dev> | 2024-03-28 05:23:23 +0200 |
| commit | 5efa2ddf62d4876fb62f23b571f4cc0af5885639 (patch) | |
| tree | 4dca9f58af263171afda916314f55d75fa20d68f | |
| parent | 5a7c46355be1b5a9a8dbfb36ba44969963a3f558 (diff) | |
| download | emacs-5efa2ddf62d4876fb62f23b571f4cc0af5885639.tar.gz | |
Correctly check buffer mtime when displaying xref matches
This was just a typo: we were checking the modification time of
current-buffer instead of checking the modification time of the
passed-in buffer.
This caused matches to not be shown if they weren't present in
the current in-Emacs state of the buffer.
This was easily reproduced by writing a string to a file outside
Emacs, then searching for that string with
e.g. project-find-regexp. The string would seemingly not be
found, although in reality it was found, just not displayed.
* lisp/progmodes/xref.el (xref--find-file-buffer):
Check buf, not current-buffer (bug#70008).
| -rw-r--r-- | lisp/progmodes/xref.el | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 717b837a2e5..755c3db04fd 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -2176,7 +2176,7 @@ Such as the current syntax table and the applied syntax properties." (or (buffer-modified-p buf) (unless xref--hits-remote-id - (not (verify-visited-file-modtime (current-buffer)))))) + (not (verify-visited-file-modtime buf))))) ;; We can't use buffers whose contents diverge from disk (bug#54025). (setq buf nil)) (setq xref--last-file-buffer (cons file buf)))) |