summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Kangas <stefan@marxist.se>2021-01-29 02:47:38 +0100
committerStefan Kangas <stefan@marxist.se>2021-01-29 06:19:06 +0100
commitbab133e6d0bff03e5ddd7f43eca169f4843d5860 (patch)
tree6260a91971a763165b5620f7e4359dc4e5edfa39
parent3ddea271cc9542e29829629991a4073ab3cf5db9 (diff)
downloademacs-bab133e6d0bff03e5ddd7f43eca169f4843d5860.tar.gz
Use lexical-binding in find-cmd.el and add tests
* lisp/find-cmd.el: Use lexical-binding. * test/lisp/find-cmd-tests.el: New file.
-rw-r--r--lisp/find-cmd.el4
-rw-r--r--test/lisp/find-cmd-tests.el45
2 files changed, 47 insertions, 2 deletions
diff --git a/lisp/find-cmd.el b/lisp/find-cmd.el
index 5866b308551..bb2e97d8662 100644
--- a/lisp/find-cmd.el
+++ b/lisp/find-cmd.el
@@ -1,4 +1,4 @@
-;;; find-cmd.el --- Build a valid find(1) command with sexps
+;;; find-cmd.el --- Build a valid find(1) command with sexps -*- lexical-binding: t -*-
;; Copyright (C) 2008-2021 Free Software Foundation, Inc.
@@ -28,7 +28,7 @@
;; (find-cmd '(prune (name ".svn" ".git" ".CVS"))
;; '(and (or (name "*.pl" "*.pm" "*.t")
;; (mtime "+1"))
-;; (fstype "nfs" "ufs"))))
+;; (fstype "nfs" "ufs")))
;; will become (un-wrapped):
diff --git a/test/lisp/find-cmd-tests.el b/test/lisp/find-cmd-tests.el
new file mode 100644
index 00000000000..b8e0f273988
--- /dev/null
+++ b/test/lisp/find-cmd-tests.el
@@ -0,0 +1,45 @@
+;;; find-cmd-tests.el --- tests for find-cmd.el. -*- lexical-binding: t -*-
+
+;; Copyright (C) 2021 Free Software Foundation, Inc.
+
+;; This file is part of GNU Emacs.
+
+;; GNU Emacs is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; GNU Emacs is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Code:
+
+(require 'ert)
+(require 'find-cmd)
+
+(ert-deftest find-cmd-test-find-cmd ()
+ (should
+ (string-match
+ (rx "find " (+ any)
+ " \\( \\( -name .svn -or -name .git -or -name .CVS \\)"
+ " -prune -or -true \\)"
+ " \\( \\( \\(" " -name \\*.pl -or -name \\*.pm -or -name \\*.t \\)"
+ " -or -mtime \\+1 \\) -and \\( -fstype nfs -or -fstype ufs \\) \\) ")
+ (find-cmd '(prune (name ".svn" ".git" ".CVS"))
+ '(and (or (name "*.pl" "*.pm" "*.t")
+ (mtime "+1"))
+ (fstype "nfs" "ufs"))))))
+
+(ert-deftest find-cmd-test-find-cmd/error-unknown-atom ()
+ (should-error (find-cmd '(unknown 123))))
+
+(ert-deftest find-cmd-test-find-cmd/error-wrong-argnum ()
+ (should-error (find-cmd '(name))))
+
+(provide 'find-cmd-tests)
+;;; find-cmd-tests.el ends here