summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Lopez <daniel.lopez999@gmail.com>2019-02-14 16:05:10 +0000
committerEli Zaretskii <eliz@gnu.org>2019-02-15 09:59:16 +0200
commit3cba92d42ecf2156296b5f05c07a3d1ded78218e (patch)
treeda425a16d9f0637e7a5028164c5aa9fbb37f3193
parent834ca187b855b4a2c532b1660bf02de401344f0f (diff)
downloademacs-3cba92d42ecf2156296b5f05c07a3d1ded78218e.tar.gz
Fix faces in compilation messages
* lisp/progmodes/compile.el (compilation-parse-errors): Don't clobber the value of TYPE inside the loop. (Bug#34479) Copyright-paperwork-exempt: yes
-rw-r--r--lisp/progmodes/compile.el22
1 files changed, 11 insertions, 11 deletions
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index a5dcbd7d384..5312a55a258 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1429,17 +1429,17 @@ to `compilation-error-regexp-alist' if RULES is nil."
file line end-line col end-col (or type 2) fmt))
(when (integerp file)
- (setq type (if (consp type)
- (compilation-type type)
- (or type 2)))
- (compilation--note-type type)
-
- (compilation--put-prop
- file 'font-lock-face
- (symbol-value (aref [compilation-info-face
- compilation-warning-face
- compilation-error-face]
- type))))
+ (let ((this-type (if (consp type)
+ (compilation-type type)
+ (or type 2))))
+ (compilation--note-type type)
+
+ (compilation--put-prop
+ file 'font-lock-face
+ (symbol-value (aref [compilation-info-face
+ compilation-warning-face
+ compilation-error-face]
+ this-type)))))
(compilation--put-prop
line 'font-lock-face compilation-line-face)