diff options
| author | Morgan Smith <Morgan.J.Smith@outlook.com> | 2023-06-05 13:34:59 -0400 |
|---|---|---|
| committer | Eli Zaretskii <eliz@gnu.org> | 2023-06-10 12:10:40 +0300 |
| commit | 0d8b69e0ad37fe2d801e16a0ccafd8759dd33d02 (patch) | |
| tree | bfe6d07693520e189baf74326026c22a3f5a59e0 | |
| parent | f11e2d369995ffc514005578857e5b7819e779eb (diff) | |
| download | emacs-0d8b69e0ad37fe2d801e16a0ccafd8759dd33d02.tar.gz | |
Don't ding when completion succeeded
* lisp/minibuffer.el (minibuffer-completion-help): Ensure 'ding'
is not called on a successful completion. Ensure 'ding' is not
called on a failure if 'completion-fail-discreetly' is set.
Also change "No completions" to "No match" as that is what is
used elsewhere. (Bug#63913)
| -rw-r--r-- | lisp/minibuffer.el | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index a873e5f9747..44226449af2 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -2388,9 +2388,11 @@ These include: ;; If there are no completions, or if the current input is already ;; the sole completion, then hide (previous&stale) completions. (minibuffer-hide-completions) - (ding) - (completion--message - (if completions "Sole completion" "No completions"))) + (if completions + (completion--message "Sole completion") + (unless completion-fail-discreetly + (ding) + (completion--message "No match")))) (let* ((last (last completions)) (base-size (or (cdr last) 0)) |