diff options
| author | João Távora <joaotavora@gmail.com> | 2023-10-18 05:48:49 -0500 |
|---|---|---|
| committer | João Távora <joaotavora@gmail.com> | 2023-10-18 07:37:57 -0500 |
| commit | e93d99a4a0ce578249304dce350465c580a49892 (patch) | |
| tree | 044abf4883ddc2fd5301c6d2e954acd667924426 /etc/EGLOT-NEWS | |
| parent | 06fc5c24170b820939d3d51071b2957354edcb65 (diff) | |
| download | emacs-e93d99a4a0ce578249304dce350465c580a49892.tar.gz | |
Eglot: respect completion sort order dictated by the server
Don't use flex style to do any completion sorting.
Previously, it was thought that the 'flex' completion style was only
kicking in to do (approximate) fontification of the completions
returned by the server, but it was found that it was also doing some
its own sorting in certain situation of non-empty matching patterns.
Replaced it with a new eglot--dumb-flex style which does only
fontification.
Github-reference: https://github.com/joaotavora/eglot/discussions/1306
* lisp/progmodes/eglot.el (eglot-completion-at-point): Rework.
(eglot--dumb-flex, eglot--dumb-allc): New helpers.
(completion-category-defaults): Rework Eglot-specific category.
(completion-styles-alist): Add Eglot-specific style.
* etc/EGLOT-NEWS: Mention change.
Diffstat (limited to 'etc/EGLOT-NEWS')
| -rw-r--r-- | etc/EGLOT-NEWS | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/etc/EGLOT-NEWS b/etc/EGLOT-NEWS index f5f78ccd483..2f54dc43cbf 100644 --- a/etc/EGLOT-NEWS +++ b/etc/EGLOT-NEWS @@ -43,6 +43,12 @@ For 'newline' commands, Eglot sometimes sent the wrong character code to the server. Also made this feature less chatty in the mode-line and messages buffer. +** Fixed completion sorting + +In some situations, Eglot was not respecting the completion sort order +decided by the language server, falling back on the sort order +determined by the 'flex' completion style instead. See github#1306. + ** Improve mouse invocation of code actions When invoking code actions by middle clicking with the mouse on |