diff options
| author | Chong Yidong <cyd@gnu.org> | 2012-07-13 15:06:09 +0800 |
|---|---|---|
| committer | Chong Yidong <cyd@gnu.org> | 2012-07-13 15:06:09 +0800 |
| commit | b68b33375caeb82a4b3418d43c75bc8ccd43633a (patch) | |
| tree | 2e14569d03369d1de85cfd81bb5a404373ec1245 /lisp/buff-menu.el | |
| parent | 1a95276708930fe579fff152c590df875c29570e (diff) | |
| download | emacs-b68b33375caeb82a4b3418d43c75bc8ccd43633a.tar.gz | |
Don't warn on toggle-read-only calls.
Clarify the documentation of toggle-read-only, and audit the code tree
for uses of toggle-read-only; where appropriate, switch to setting the
variable buffer-read-only or calling toggle-read-only with a (new)
second arg.
* lisp/files.el (toggle-read-only): Doc fix and code cleanup. New arg
to allow printing the message when called from Lisp.
* lisp/emacs-lisp/bytecomp.el (byte-compile-interactive-only-functions):
Remove toggle-read-only.
* lisp/bindings.el (mode-line-toggle-read-only):
* lisp/dired.el (dired-toggle-read-only):
* lisp/ibuffer.el (ibuffer-do-toggle-read-only): Call toggle-read-only
with non-nil second arg.
* lisp/bs.el (bs-toggle-readonly):
* lisp/buff-menu.el (Buffer-menu-toggle-read-only): Remove
with-no-warnings around toggle-read-only.
* lisp/ffap.el (ffap--toggle-read-only): Accept a list of buffers.
Remove with-no-warnings around toggle-read-only.
(ffap-read-only, ffap-read-only-other-window)
(ffap-read-only-other-frame): Callers changed.
* lisp/help-mode.el: Don't require view package.
(help-mode-finish): Set buffer-read-only instead of calling
toggle-read-only.
* lisp/emacs-lisp/eieio-custom.el (eieio-customize-object):
* lisp/vc/ediff.el (ediff-set-read-only-in-buf-A): Set buffer-read-only
directly.
* lisp/gnus/smime.el (smime-certificate-info): Set buffer-read-only directly,
instead of calling toggle-read-only with a (bogus) argument.
* doc/emacs/buffers.texi (Misc Buffer): Document view-read-only.
* doc/lispref/buffers.texi (Read Only Buffers): Document toggle-read-only
changes. Reword to account for the fact that read-only is currently not
supported in overlay properties.
Diffstat (limited to 'lisp/buff-menu.el')
| -rw-r--r-- | lisp/buff-menu.el | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index ab1de184ea0..6a65749e0c5 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -515,11 +515,12 @@ The current window remains selected." (bury-buffer menu))) (defun Buffer-menu-toggle-read-only () - "Toggle read-only status of buffer on this line." + "Toggle read-only status of buffer on this line. +This behaves like invoking \\[toggle-read-only] in that buffer." (interactive) (let (read-only) (with-current-buffer (Buffer-menu-buffer t) - (with-no-warnings (toggle-read-only)) + (toggle-read-only) (setq read-only buffer-read-only)) (tabulated-list-set-col 1 (if read-only "%" " ") t))) |