summaryrefslogtreecommitdiff
path: root/lisp/gnus/nndiary.el
diff options
context:
space:
mode:
authorMattias EngdegÄrd <mattiase@acm.org>2023-04-11 11:57:07 +0200
committerMattias EngdegÄrd <mattiase@acm.org>2023-04-11 11:57:07 +0200
commitfb66e4d58bbc24abf44157078e8ca51ffed93113 (patch)
treea2a4ae3af06920e64ce3fdfbfe8b991677007629 /lisp/gnus/nndiary.el
parent5dab172a17320e93332ae6545738b37f4224f2de (diff)
downloademacs-fb66e4d58bbc24abf44157078e8ca51ffed93113.tar.gz
nndiary.el: fix dodgy schedule code
* lisp/gnus/nndiary.el (nndiary-last-occurrence): Don't sort a list and throw away the result because that leaves the list variable in an undefined state. Just take the largest element because that was obviously what the author meant.
Diffstat (limited to 'lisp/gnus/nndiary.el')
-rw-r--r--lisp/gnus/nndiary.el4
1 files changed, 2 insertions, 2 deletions
diff --git a/lisp/gnus/nndiary.el b/lisp/gnus/nndiary.el
index be2bdc9bb15..8728aab1def 100644
--- a/lisp/gnus/nndiary.el
+++ b/lisp/gnus/nndiary.el
@@ -1373,10 +1373,10 @@ all. This may very well take some time.")
(setq day (+ 7 day))))
;; Finally, if we have some days, they are valid
(when days
- (sort days #'>)
(throw 'found
(encode-time 0 minute hour
- (car days) month year time-zone)))
+ (apply #'max days)
+ month year time-zone)))
)))))
;; There's an upper limit, but we didn't find any last occurrence.
;; This means that the schedule is undecidable. This can happen if