summaryrefslogtreecommitdiff
path: root/lisp/ls-lisp.el
diff options
context:
space:
mode:
authorTino Calancha <tino.calancha@gmail.com>2017-08-02 18:11:31 +0900
committerTino Calancha <tino.calancha@gmail.com>2017-08-02 18:11:43 +0900
commitcf1da46761675f1886e54765fa213c7bd7d93437 (patch)
tree50ea0085753122e956d8221258ed47fd2794e3e6 /lisp/ls-lisp.el
parent49d6e59717ad182487910b863656bb6a11080bcf (diff)
downloademacs-cf1da46761675f1886e54765fa213c7bd7d93437.tar.gz
ls-lisp: Autoload call instead of cookie
* lisp/ls-lisp.el (eshell-extended-glob): autoload call instead of cookie.
Diffstat (limited to 'lisp/ls-lisp.el')
-rw-r--r--lisp/ls-lisp.el11
1 files changed, 8 insertions, 3 deletions
diff --git a/lisp/ls-lisp.el b/lisp/ls-lisp.el
index 2f723ca8ac8..9a4fc197442 100644
--- a/lisp/ls-lisp.el
+++ b/lisp/ls-lisp.el
@@ -479,14 +479,19 @@ not contain `d', so that a full listing is expected."
(message "%s: doesn't exist or is inaccessible" file)
(ding) (sit-for 2))))) ; to show user the message!
-
-(declare-function eshell-extended-glob "em-glob" (glob))
+;; We cannot require 'em-glob' in the top of the file:
+;; ls-lisp is compiled before than eshell, and esh-groups.el
+;; wouldn't be created yet. If we require 'em-glob' inside
+;; `ls-lisp--dired', then this function cannot be called
+;; before eshell is compiled.
+;; So instead we add an autoload call here.
+;; (https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg01083.html).
+(autoload 'eshell-extended-glob "em-glob")
(declare-function dired-read-dir-and-switches "dired" (str))
(declare-function dired-goto-next-file "dired" ())
(defun ls-lisp--dired (orig-fun dir-or-list &optional switches)
(interactive (dired-read-dir-and-switches ""))
- (require 'em-glob)
(if (consp dir-or-list)
(funcall orig-fun dir-or-list switches)
(let ((dir-wildcard (insert-directory-wildcard-in-dir-p