diff options
| author | Mattias Engdegård <mattiase@acm.org> | 2023-04-14 18:26:27 +0200 |
|---|---|---|
| committer | Mattias Engdegård <mattiase@acm.org> | 2023-04-14 19:34:23 +0200 |
| commit | c60b59e04c3776a90adaa8c8fe53af3075a833b8 (patch) | |
| tree | 55b5586eee1749ef451982b5edcf4f65666d0b9c /src/lisp.h | |
| parent | dc842a71ed035dab1115f2e67d35dd07410e18be (diff) | |
| download | emacs-c60b59e04c3776a90adaa8c8fe53af3075a833b8.tar.gz | |
Disallow creation of circular variable alias chains
Make `defvaralias` signal an error upon attempts to create variable
alias cycles. This detects errors earlier and makes the alias
traversal during execution simpler and faster since no cycle detection
is needed elsewhere.
Now variable and function aliases are handled identically in these
respects.
* src/lisp.h (indirect_variable): Remove declaration.
* src/data.c (indirect_variable): Remove.
(Findirect_variable): Update doc string. Simplify alias resolution.
(Fboundp, find_symbol_value, set_internal, default_value)
(set_default_internal, Fmake_variable_buffer_local)
(Fmake_local_variable, Fkill_local_variable, Flocal_variable_p)
(Flocal_variable_if_set_p, Fvariable_binding_locus):
* src/buffer.c (buffer_local_value):
* src/eval.c (specbind): Simplify variable alias resolution.
(Fdefvaralias): Update doc string. Check for cycles.
* doc/lispref/variables.texi (Variable Aliases):
Mention that `defvaralias` can signal `cyclic-variable-indirection`
but `indirect-variable` cannot.
* etc/NEWS: Announce the change.
* test/src/eval-tests.el (eval-tests-defvaralias): New test.
Diffstat (limited to 'src/lisp.h')
| -rw-r--r-- | src/lisp.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/lisp.h b/src/lisp.h index 165fa47b0b3..78b68880702 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -3965,7 +3965,6 @@ extern Lisp_Object arithcompare (Lisp_Object num1, Lisp_Object num2, extern intmax_t cons_to_signed (Lisp_Object, intmax_t, intmax_t); extern uintmax_t cons_to_unsigned (Lisp_Object, uintmax_t); -extern struct Lisp_Symbol *indirect_variable (struct Lisp_Symbol *); extern AVOID args_out_of_range (Lisp_Object, Lisp_Object); extern AVOID circular_list (Lisp_Object); extern Lisp_Object do_symval_forwarding (lispfwd); |