diff options
| author | Paul Eggert <eggert@cs.ucla.edu> | 2012-09-11 15:59:50 -0700 |
|---|---|---|
| committer | Paul Eggert <eggert@cs.ucla.edu> | 2012-09-11 15:59:50 -0700 |
| commit | ae1d87e24edc6a5fa4bc291e1b2ea20d7853127c (patch) | |
| tree | 200f48e41018df77fb2f63e55e0d22c829968ebe /src/xgselect.c | |
| parent | 5779a1dc62593be8294edaecfecca4359be9ab4e (diff) | |
| download | emacs-ae1d87e24edc6a5fa4bc291e1b2ea20d7853127c.tar.gz | |
Prefer assignment to memcpy when either will do.
* lib-src/pop.c (socket_connection) [HAVE_GETADDRINFO]:
* src/bidi.c (bidi_push_it, bidi_pop_it):
* src/fns.c (copy_hash_table):
* src/image.c (define_image_type):
* src/keyboard.c (kbd_buffer_store_event_hold):
* src/process.c (Fprocess_send_eof):
* src/xfaces.c (x_create_gc) [HAVE_NS]:
* src/xgselect.c (xg_select):
Use assignment, not memcpy, as either will do here, and assignment is
more likely to catch type errors.
Diffstat (limited to 'src/xgselect.c')
| -rw-r--r-- | src/xgselect.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/xgselect.c b/src/xgselect.c index 0c00d815820..5f4c7edfb79 100644 --- a/src/xgselect.c +++ b/src/xgselect.c @@ -49,9 +49,9 @@ xg_select (int fds_lim, SELECT_TYPE *rfds, SELECT_TYPE *wfds, SELECT_TYPE *efds, && g_main_context_pending (context = g_main_context_default ()))) return pselect (fds_lim, rfds, wfds, efds, timeout, sigmask); - if (rfds) memcpy (&all_rfds, rfds, sizeof (all_rfds)); + if (rfds) all_rfds = *rfds; else FD_ZERO (&all_rfds); - if (wfds) memcpy (&all_wfds, wfds, sizeof (all_rfds)); + if (wfds) all_wfds = *wfds; else FD_ZERO (&all_wfds); n_gfds = g_main_context_query (context, G_PRIORITY_LOW, &tmo_in_millisec, |