summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorPhilipp Stephani <phst@google.com>2021-01-23 18:39:20 +0100
committerPhilipp Stephani <phst@google.com>2021-01-23 18:39:20 +0100
commit59e9ec72442d264a3e08c9886ad3b49fa8dc9f37 (patch)
treeefd5349cbd8d4ef2d1220f7622bd21135e57a84f /src
parentaeff424c555da7e80775482db84eecef10286fc3 (diff)
downloademacs-59e9ec72442d264a3e08c9886ad3b49fa8dc9f37.tar.gz
Add a FIXME comment to improve the SIGCHLD race condition handling.
* src/process.c: Add FIXME comment describing how we could avoid the self-pipe on modern Unix-like systems.
Diffstat (limited to 'src')
-rw-r--r--src/process.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/process.c b/src/process.c
index 9b1de19f0ae..8abdcd4f0c1 100644
--- a/src/process.c
+++ b/src/process.c
@@ -7164,6 +7164,11 @@ process has been transmitted to the serial port. */)
because that emulation delays the delivery of the simulated SIGCHLD
until all the output from the subprocess has been consumed. */
+/* FIXME: On Unix-like systems that have a proper 'pselect'
+ (HAVE_PSELECT), we should block SIGCHLD in
+ 'wait_reading_process_output' and pass a non-NULL signal mask to
+ 'pselect' to avoid the need for the self-pipe. */
+
/* Set up `child_signal_read_fd' and `child_signal_write_fd'. */
static void