diff options
| author | Sean Whitton <spwhitton@spwhitton.name> | 2021-10-06 11:36:25 -0700 |
|---|---|---|
| committer | Sean Whitton <spwhitton@spwhitton.name> | 2021-10-29 11:48:41 -0700 |
| commit | 7e73746220aacc750c30340e9a960f839baa228e (patch) | |
| tree | 1faf054619fa0f99966cdebe6846608657594b8b /src/connection | |
| parent | 8837b71e02d93787de60d454a493a8801a6427a5 (diff) | |
| download | consfigurator-7e73746220aacc750c30340e9a960f839baa228e.tar.gz | |
add & propagate :NO-SERVICES connattr and respect in LIBVIRT:STARTED
This change was prompted by the realisation that RECONNECTS nullifies any
enclosing SERVICE:WITHOUT-STARTING-SERVICES because *HOST* during RECONNECTS
is a distinct HOST value, computed at hostattrs time, which can't be affected
by an enclosing combinator that works by temporarily pushing hostattrs at
:APPLY time. So, for example, if we chroot and subsequently establish a
:SETUID connection, properties might try to start services as the non-root
user and there is no way for them to know they shouldn't.
We can avoid this problem by using a connattr instead because we have a
mechanism for propagating connattrs to subsequently established connections.
And as in most cases the reason for not starting services is solely due to the
way in which we're connecting to the host, a connattr is more appropriate.
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
Diffstat (limited to 'src/connection')
| -rw-r--r-- | src/connection/chroot.lisp | 4 | ||||
| -rw-r--r-- | src/connection/setuid.lisp | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/src/connection/chroot.lisp b/src/connection/chroot.lisp index 5c149e3..8f829d3 100644 --- a/src/connection/chroot.lisp +++ b/src/connection/chroot.lisp @@ -86,6 +86,10 @@ should be the mount point, without the chroot's root prefixed.") ((type (eql :remote-gid)) connattr (connection chroot-connection)) connattr) +(defmethod propagate-connattr + ((type (eql :no-services)) connattr (connection chroot-connection)) + connattr) + ;;;; :CHROOT.FORK diff --git a/src/connection/setuid.lisp b/src/connection/setuid.lisp index 2036146..59b9e67 100644 --- a/src/connection/setuid.lisp +++ b/src/connection/setuid.lisp @@ -65,3 +65,7 @@ user (connection-connattr connection :remote-home)) ;; We are privileged, so this sets the real, effective and saved IDs. (nix:setgid gid) (nix:initgroups user gid) (nix:setuid uid))) + +(defmethod propagate-connattr + ((type (eql :no-services)) connattr (connection setuid-connection)) + connattr) |