add & propagate :NO-SERVICES connattr and respect in LIBVIRT:STARTED

This change was prompted by the realisation that RECONNECTS nullifies any
enclosing SERVICE:WITHOUT-STARTING-SERVICES because *HOST* during RECONNECTS
is a distinct HOST value, computed at hostattrs time, which can't be affected
by an enclosing combinator that works by temporarily pushing hostattrs at
:APPLY time.  So, for example, if we chroot and subsequently establish a
:SETUID connection, properties might try to start services as the non-root
user and there is no way for them to know they shouldn't.

We can avoid this problem by using a connattr instead because we have a
mechanism for propagating connattrs to subsequently established connections.
And as in most cases the reason for not starting services is solely due to the
way in which we're connecting to the host, a connattr is more appropriate.

Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>

1 files changed, 5 insertions, 1 deletions

diff --git a/src/deployment.lisp b/src/deployment.lisp
index 444972a..097bb9b 100644
--- a/src/deployment.lisp
+++ b/src/deployment.lisp
@@ -306,7 +306,11 @@ PROPERTIES, like DEPLOY-THESE."
 (defprop reconnects :posix (connections properties)
   "Connect back to the same host with CONNECTIONS and apply PROPERTIES.
 Mainly useful for using a connection type like :AS to apply properties as a
-different user."
+different user.
+
+Combinators that work by temporarily pushing hostattrs at :APPLY time will not
+be able to affect PROPERTIES in an application of RECONNECTS they enclose.
+Connection attributes, by contrast, are propagated as usual."
   (:desc (declare (ignore properties))
          (format nil "~S reconnection" connections))
   (:preprocess