aboutsummaryrefslogtreecommitdiff
path: root/src/property
diff options
context:
space:
mode:
authorSean Whitton <spwhitton@spwhitton.name>2022-04-28 14:42:11 -0700
committerSean Whitton <spwhitton@spwhitton.name>2022-04-28 16:06:58 -0700
commitd5093e17943bf10f94e5326b4c727b2f13606298 (patch)
tree8121c6d68ff9092615baba0cc7b0f2a52d4c21ee /src/property
parentb1479617a001ca3dbb1216f8609d39914aecd8bb (diff)
downloadconsfigurator-d5093e17943bf10f94e5326b4c727b2f13606298.tar.gz
FSTAB:HAS-ENTRIES-FOR-OPENED-VOLUMES: note bug for fat32 partitions
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
Diffstat (limited to 'src/property')
-rw-r--r--src/property/fstab.lisp6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/property/fstab.lisp b/src/property/fstab.lisp
index 34f1d04..43c0caa 100644
--- a/src/property/fstab.lisp
+++ b/src/property/fstab.lisp
@@ -101,6 +101,12 @@ specified with DISK:HAS-VOLUMES."
(curry #'subvolumes-of-type 'filesystem)
(or volumes (get-hostattrs :volumes))))))))
+;; TODO This is broken for fat32 partitions. MOUNTED-FAT32-FILESYSTEM objects
+;; are pushed directly to the connattr by DISK:WITH-THESE-OPEN-VOLUMES, rather
+;; than appearing within OPENED-PARTITION objects. Then the call to
+;; SUBVOLUMES-OF-TYPE here never finds any parents, returning as a second
+;; value a list containing only NIL. Thus the specialisers in the
+;; implementation of FS-SPEC for MOUNTED-FAT32-FILESYSTEM are never satisfied.
(defprop has-entries-for-opened-volumes :posix ()
"Add or update entries in /etc/fstab for currently open volumes.