summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEli Zaretskii <eliz@gnu.org>2021-01-01 13:52:37 +0200
committerEli Zaretskii <eliz@gnu.org>2021-01-01 13:52:37 +0200
commit7384ec6416cbcea12a65db058e5a65e40d3a157f (patch)
tree0c22930f08923abb2018b5ac35356ef5aaf200f7
parent3711339f92be0c50633aefae991d8fa4a135fe33 (diff)
downloademacs-7384ec6416cbcea12a65db058e5a65e40d3a157f.tar.gz
Add warning comments abound binding keys in Isearch maps
* lisp/isearch.el (isearch-mode-map) (minibuffer-local-isearch-map): Add comments which warn against wantonly rebinding unbound keys.
-rw-r--r--lisp/isearch.el8
1 files changed, 8 insertions, 0 deletions
diff --git a/lisp/isearch.el b/lisp/isearch.el
index ac0ebc735d5..cbe72efb801 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -655,6 +655,10 @@ This is like `describe-bindings', but displays only Isearch keys."
(if isearch-success 'isearch-abort binding))))
map))
+;; Note: Before adding more key bindings to this map, please keep in
+;; mind that any unbound key exits Isearch and runs the command bound
+;; to it in the local or global map. So in effect every key unbound
+;; in this map is implicitly bound.
(defvar isearch-mode-map
(let ((i 0)
(map (make-keymap)))
@@ -819,6 +823,10 @@ This is like `describe-bindings', but displays only Isearch keys."
:image '(isearch-tool-bar-image "left-arrow")))
map))
+;; Note: Before adding more key bindings to this map, please keep in
+;; mind that any unbound key exits Isearch and runs the command bound
+;; to it in the local or global map. So in effect every key unbound
+;; in this map is implicitly bound.
(defvar minibuffer-local-isearch-map
(let ((map (make-sparse-keymap)))
(set-keymap-parent map minibuffer-local-map)