use Term::ReadKey in annex-review-unused

1 files changed, 19 insertions, 9 deletions

diff --git a/lib/perl5/Local/MrRepo/Repo/Git/Annex.pm b/lib/perl5/Local/MrRepo/Repo/Git/Annex.pm
index 09d1e5da..3d80c827 100644
--- a/lib/perl5/Local/MrRepo/Repo/Git/Annex.pm
+++ b/lib/perl5/Local/MrRepo/Repo/Git/Annex.pm
@@ -151,20 +151,30 @@ sub review_unused {
             if ($opts{interactive}) {
                 my $response;
                 while (1) {
+                    # before prompting, clear out stdin, to avoid
+                    # registered a keypress more than once
+                    ReadMode 4;
+                    while (defined ReadKey(-1)) {}
+
                     # would be good if user could say 'b' to go back
                     # to the previous entry.  would probably have to
                     # implement this by replacing the foreach loop
                     # with a while loop with a manually maintained
                     # array index into @unused_files.
-                    #
-                    # would also be good not to require the user to
-                    # hit RET, possibly by using Term::ReadKey (see
-                    # example code in its POD).
-                    #
-                    # if do that, add a small delay before accepting
-                    # the next keypress, to reduce the chance of two
-                    # keypresses being accidentally registered
-                    $response = lc(prompt("Drop this unused file?  (y/n/o)"));
+                    print "Drop this unused file?  (y/n/o) ";
+
+                    # Term::ReadKey docs recommend ReadKey(-1) but
+                    # that means we need an infinite loop calling
+                    # ReadKey(-1) over and over, which ramps up system
+                    # load
+                    my $response = ReadKey(0);
+                    ReadMode 0;
+                    print "\n";
+
+                    # respond to C-c
+                    exit 0 if ord($response) == 3;
+
+                    $response = lc($response);
                     if ($response eq 'y') {
                         push @to_drop, $unused_file->{number};
                         last;